Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] New API stack on by default for PPO. #48284

Merged
merged 23 commits into from
Nov 3, 2024
Merged

[RLlib] New API stack on by default for PPO. #48284

merged 23 commits into from
Nov 3, 2024

Conversation

sven1977
Copy link
Contributor

New API stack on by default for PPO.

To switch back the old API stack, do:

config.api_stack(
    enable_rl_module_and_learner=False,
    enable_env_runner_and_connector_v2=False,
)

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
ee7da8a 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
09ad624 
…api_stack_on_by_default_ppo
@sven1977
wip
502ea27 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
simonsays1980
simonsays1980 approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Dumb question: If PPO is now new API stack by default, can't we just set this in the PPOConfig instead of setting api_stack to True for enable_rl_module_and_learner and enable_env_runner_and_connector_v2?

rllib/tests/test_dependency_tf.py Outdated
@@ -22,6 +22,10 @@

config = (
PPOConfig()
.api_stack(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the hybrid stack is off?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we run this test anymore ...

@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
a71857b 
…api_stack_on_by_default_ppo

Signed-off-by: sven1977 <svenmika1977@gmail.com>

# Conflicts:
#	rllib/utils/exploration/tests/test_curiosity.py
@sven1977
wip
9492970 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
37c32bf 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) October 28, 2024 11:17
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 28, 2024
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
3e3d2a3 
…api_stack_on_by_default_ppo

Signed-off-by: sven1977 <svenmika1977@gmail.com>

# Conflicts:
#	doc/source/rllib/doc_code/rllib_in_60s.py
#	rllib/algorithms/tests/test_env_runner_failures.py
#	rllib/utils/exploration/tests/test_curiosity.py
@github-actions github-actions bot disabled auto-merge November 1, 2024 09:17
sven1977 added 15 commits November 1, 2024 11:36
@sven1977
wip
45506cd 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
6fe1862 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
4ba8bba 
…api_stack_on_by_default_ppo

Signed-off-by: sven1977 <svenmika1977@gmail.com>

# Conflicts:
#	rllib/utils/exploration/tests/test_curiosity.py
@sven1977
wip
f28bc8c 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
0a31427 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
ab3ab2d 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
8be9288 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
8280a8a 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
e02ea3f 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
db55232 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
c9b0a31 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
f5fa6c1 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
4f6742c 
…api_stack_on_by_default_ppo
@sven1977
wip
2776fe9 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
18fcaa5 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
478d00f 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) November 3, 2024 18:32
@sven1977 sven1977 merged commit 62d7f4b into ray-project:master Nov 3, 2024
6 checks passed
@sven1977 sven1977 deleted the new_api_stack_on_by_default_ppo branch November 3, 2024 23:05
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@sven1977 @Jay-ju
[RLlib] New API stack on by default for PPO. (ray-project#48284)
a5fdd9f
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@sven1977 @JP-sDEV
[RLlib] New API stack on by default for PPO. (ray-project#48284)
d237a18 
Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@sven1977 @mohitjain2504
[RLlib] New API stack on by default for PPO. (ray-project#48284)
c659af1 
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980